ashb commented on a change in pull request #4523: [AIRFLOW-3616] Add aliases 
for schema with underscore
URL: https://github.com/apache/airflow/pull/4523#discussion_r249109716
 
 

 ##########
 File path: tests/models.py
 ##########
 @@ -3077,6 +3077,23 @@ def test_connection_from_uri_no_schema(self):
         self.assertEqual(connection.password, 'password with space')
         self.assertEqual(connection.port, 1234)
 
+    def test_connection_from_uri_with_underscore(self):
+        uri = 'google-cloud-platform:/?extra__google_cloud_platform__key_' \
 
 Review comment:
   ```suggestion
           uri = 'google-cloud-platform://?extra__google_cloud_platform__key_' \
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to