mik-laj commented on a change in pull request #4524: [AIRFLOW-3707] Group subpackages by cloud providers URL: https://github.com/apache/airflow/pull/4524#discussion_r249193359
########## File path: setup.py ########## @@ -211,27 +217,44 @@ def write_version(filename=os.path.join(*['airflow', qds = ['qds-sdk>=1.10.4'] rabbitmq = ['librabbitmq>=1.6.1'] redis = ['redis>=2.10.5,<3.0.0'] -s3 = ['boto3>=1.7.0, <1.8.0'] salesforce = ['simple-salesforce>=0.72'] samba = ['pysmbclient>=0.1.3'] segment = ['analytics-python>=1.2.9'] sendgrid = ['sendgrid>=5.2.0'] slack = ['slackclient>=1.0.0'] mongo = ['pymongo>=3.6.0'] -snowflake = ['snowflake-connector-python>=1.5.2', - 'snowflake-sqlalchemy>=1.1.0'] -ssh = ['paramiko>=2.1.1', 'pysftp>=0.2.9', 'sshtunnel>=0.1.4,<0.2'] +snowflake = [ + 'snowflake-connector-python>=1.5.2', + 'snowflake-sqlalchemy>=1.1.0', +] +ssh = [ + 'paramiko>=2.1.1', + 'pysftp>=0.2.9', + 'sshtunnel>=0.1.4,<0.2', +] statsd = ['statsd>=3.0.1, <4.0'] vertica = ['vertica-python>=0.5.1'] webhdfs = ['hdfs[dataframe,avro,kerberos]>=2.0.4'] winrm = ['pywinrm==0.2.2'] zendesk = ['zdesk'] -all_dbs = postgres + mysql + hive + mssql + hdfs + vertica + cloudant + druid + pinot \ - + cassandra + mongo +all_dbs = ( + postgres + + mysql + + hive + + mssql + + hdfs + + vertica + + cloudant + + druid + + pinot + + cassandra + Review comment: I want to introduce an alphabetical order and the requirement to write one by one in a line when they have a large number of elements (When they do not fit in a 80-character line). I want to introduce it just for the git blame. Another reason is disabled people. In the future it will be easier to find where this change comes from. Unfortunately, there must be one place where this change will come so that a better tomorrow can come. However, I think that it is too small a change to create a separate PR and issues. Do you think it's better to do it in a separate PR? New PR should contain a new issues? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
