ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250979887
########## File path: tests/hooks/test_oracle_hook.py ########## @@ -0,0 +1,248 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import json +import unittest +from datetime import datetime + +import cx_Oracle Review comment: Could you guard this in an try/except and decorate the whole class with a `@unittest.skipIf`? See tests_mongo_hook for an example (but only one decorator on the whole class, not one per fn please) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
