[
https://issues.apache.org/jira/browse/AIRFLOW-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758939#comment-16758939
]
ASF GitHub Bot commented on AIRFLOW-3780:
-----------------------------------------
yiheng commented on pull request #4643: [AIRFLOW-3780] Fix some pages are
incorrectly directly after set base_url
URL: https://github.com/apache/airflow/pull/4643
Make sure you have checked all steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3780
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
We found that after set the base_url, some of the aiflow pages cannot be
redirected to correct path. The pages include:
* Task instances in the dag detail page
* The schedule interval tag in the dag detail page
* Trigger button in the dag list page
In the first two pages, the root cause is the path is hard coded. In the PR,
I change them to {{ url_for( ... ) }} to use the path generated by backend.
In the third one, the root cause is that the 'origin' param is not passed to
the backend correctly. I added a javascript function to add the origin param to
the url.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I don't know how to do test on UI link change
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
wait for travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Found some pages are incorrectly redirected after set base_url
> --------------------------------------------------------------
>
> Key: AIRFLOW-3780
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3780
> Project: Apache Airflow
> Issue Type: Bug
> Components: webserver
> Affects Versions: 1.10.1
> Reporter: Yiheng Wang
> Priority: Minor
> Fix For: 1.10.3
>
>
> Hi
> I have set the *base_url* parameter in the airflow.cfg file to integrate
> airflow GUI into our system. Most of the pages work correctly. But I still
> find some pages are not correctly redirected.
> Say I set base_url to [http://localhost:8080/workflow,] the admin page is
> [http://localhost:8080/workflow/admin.] As far as I found, these pages
> redirect to [http://localhost:8080/admin]
> * Trigger button in the dag list page
> * Task instances in the dag detail page
> * The schedule interval tag in the dag detail page
>
> Is this a bug or misconfiguration? If this is a bug, we'd like to submit a PR
> to fix them.
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
