ogirardot opened a new pull request #4678: [AIRFLOW-3857] spark_submit_hook 
cannot kill driver pod in kubernetes
URL: https://github.com/apache/airflow/pull/4678
 
 
   ### Jira
   
   - [x] My PR addresses the following 
[AIRFLOW-3857](https://issues.apache.org/jira/browse/AIRFLOW-3857) issue.
   
   ### Description
   
   - [x] The spark_submit_hook.on_kill method cannot kill a kubernetes driver 
pod because of an issue in the client used. The client used in 1.10.{0,1,2} is 
in fact the CoreV1Api instead of the kubernetes client which has the proper 
V1DeleteOptions value needed.
   
   ### Tests
   
   - [x] No test was done on this part, no test is added yet.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] No new feature, just a bug fix
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to