[ 
https://issues.apache.org/jira/browse/AIRFLOW-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tanay Tummalapalli updated AIRFLOW-3869:
----------------------------------------
    Description: 
The getboolean method of AirflowConfigParser class raises 
AirflowConfigException when the value of the configuration cannot be casted to 
bool. But, getint and getfloat raise ValueError in the same case. 

So, when getboolean cannot cast the value of the config to bool, it should 
raise ValueError.

Also, add tests for the same.

Reference:

1. [https://github.com/apache/airflow/blob/master/airflow/configuration.py#L272]

2. https://issues.apache.org/jira/browse/AIRFLOW-3742

  was:
The getboolean method of AirflowConfigParser class raises 
AirflowConfigException when the value of the configuration cannot be casted to 
bool. But, getint and getfloat raise ValueError in the same case. 

So, when getboolean cannot cast the value of the config to bool, it should 
raise ValueError.

Reference:

1. [https://github.com/apache/airflow/blob/master/airflow/configuration.py#L272]

2. https://issues.apache.org/jira/browse/AIRFLOW-3742


> raise consistent Exception in AirflowConfigParser.getboolean
> ------------------------------------------------------------
>
>                 Key: AIRFLOW-3869
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3869
>             Project: Apache Airflow
>          Issue Type: Test
>          Components: configuration
>    Affects Versions: 1.10.2
>            Reporter: Tanay Tummalapalli
>            Assignee: Tanay Tummalapalli
>            Priority: Trivial
>
> The getboolean method of AirflowConfigParser class raises 
> AirflowConfigException when the value of the configuration cannot be casted 
> to bool. But, getint and getfloat raise ValueError in the same case. 
> So, when getboolean cannot cast the value of the config to bool, it should 
> raise ValueError.
> Also, add tests for the same.
> Reference:
> 1. 
> [https://github.com/apache/airflow/blob/master/airflow/configuration.py#L272]
> 2. https://issues.apache.org/jira/browse/AIRFLOW-3742



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to