[
https://issues.apache.org/jira/browse/AIRFLOW-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765016#comment-16765016
]
ASF subversion and git services commented on AIRFLOW-3742:
----------------------------------------------------------
Commit f8776d61afb0bbd8d38c990248fe9460486b1db3 in airflow's branch
refs/heads/v1-10-test from Tanay Tummalapalli
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=f8776d6 ]
[AIRFLOW-3742] Fix handling of "fallback" for
AirflowConfigParsxer.getint/boolean (#4674)
We added (and used) fallback as an argument on `getboolean` but didn't
add it to the method, or add tests covering those "casting" accessors,
so they broke.
This fixes those methods, and adds tests covering them
> airflow.configuration doesn't respect fallback kwarg
> ----------------------------------------------------
>
> Key: AIRFLOW-3742
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3742
> Project: Apache Airflow
> Issue Type: Improvement
> Components: configuration
> Reporter: Ash Berlin-Taylor
> Assignee: Ash Berlin-Taylor
> Priority: Minor
> Fix For: 1.10.3
>
>
> The ConfigParser class we base our config parser on can optionally accept a
> fallback argument:
> {code:python}
> conf.get('sect', 'key', fallback='default')
> {code}
> but our sub-class doesn't support this. It would be nice if we did. Then we
> can turn
> {code:python}
> plugins_folder = configuration.conf.get('core', 'plugins_folder')
> if not plugins_folder:
> plugins_folder = settings.AIRFLOW_HOME + '/plugins'
> {code}
> in to this:
> {code:python}
> plugins_folder = configuration.conf.get('core', 'plugins_folder',
> fallback=settings.AIRFLOW_HOME + '/plugins')
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
