zhongjiajie commented on a change in pull request #4437: AIRFLOW-3632 Adding 
replace_microseconds parameter to dag_runs endpoint
URL: https://github.com/apache/airflow/pull/4437#discussion_r255806982
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -74,8 +77,16 @@ def trigger_dag(dag_id):
 
             return response
 
+    # Default replace_microseconds to True follow convention from 
trigger.trigger_dag
+    replace_microseconds = True
 
 Review comment:
   I think we could simplify it like below
   ```suggestion
       replace_microseconds = True
       if 'replace_microseconds' in data and 
data['replace_microseconds'].lower() not in YES_VALUES:
           replace_microseconds = False
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to