ashb opened a new pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME URL: https://github.com/apache/airflow/pull/4705 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-3743 ### Description There were a few ways of getting the AIRFLOW_HOME directory used throughout the code base, giving possibly conflicting answer if they weren't kept in sync: - the AIRFLOW_HOME environment variable - core/airflow_home from the config - settings.AIRFLOW_HOME - configuration.AIRFLOW_HOME Since the home directory is used to compute the default path of the config file to load, specifying the home directory Again in the config file didn't make any sense to me, and I have deprecated that. This commit makes everything in the code base use `settings.AIRFLOW_HOME` as the source of truth, and deprecates the core/airflow_home config option. (This issue caused me a problem where the RBAC UI wouldn't work as it didn't find the right webserver_config.py) ### Tests Existing tests pass,. ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. - All the public functions and the classes in the PR contain docstrings that explain what it does ### Code Quality - [x] Passes `flake8`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
