feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add
edges to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r256957621
##########
File path: airflow/www/views.py
##########
@@ -1349,21 +1361,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
form = GraphForm(data=dt_nr_dr_data)
form.execution_date.choices = dt_nr_dr_data['dr_choices']
- task_instances = {
+ task_instances_dict = {
Review comment:
not sure the coding style, but could we not put type in the variable
name(https://docs.quantifiedcode.com/python-anti-patterns/readability/putting_type_information_in_a_variable_name.html)
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
