XD-DENG commented on a change in pull request #4705: [AIRFLOW-3743] Unify
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r257466112
##########
File path: airflow/configuration.py
##########
@@ -530,6 +530,24 @@ def parameterized_config(template):
conf.read(AIRFLOW_CONFIG)
+if conf.has_option('core', 'AIRFLOW_HOME'):
+ if 'AIRFLOW_HOME' in os.environ:
+ warnings.warn(
+ 'Specifying both AIRFLOW_HOME environment variable and
airflow_home '
+ 'in the config file is deprecated. Please use only the
AIRFLOW_HOME '
+ 'environment variable and remove the config file entry.',
+ category=DeprecationWarning,
+ )
+ else:
+ AIRFLOW_HOME = conf.get('core', 'airflow_home')
Review comment:
Double-checking on this: so your intention is that if the user is still
using `airflow_home` in .cfg file, only a warning will be given (no hard
stoping) and the value in .cfg file will be used eventually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
