Fokko commented on a change in pull request #4724: [AIRFLOW-3906] Add npm
compile to docker file
URL: https://github.com/apache/airflow/pull/4724#discussion_r258242613
##########
File path: Dockerfile
##########
@@ -16,26 +16,39 @@
FROM python:3.6-slim
-COPY . /opt/airflow/
-
ARG AIRFLOW_HOME=/usr/local/airflow
ARG AIRFLOW_DEPS="all"
ARG PYTHON_DEPS=""
-ARG buildDeps="freetds-dev libkrb5-dev libsasl2-dev libssl-dev libffi-dev
libpq-dev git"
-ARG APT_DEPS="$buildDeps libsasl2-dev freetds-bin build-essential
default-libmysqlclient-dev apt-utils curl rsync netcat locales"
+ARG buildDeps="freetds-dev libkrb5-dev libssl-dev libffi-dev libpq-dev git"
+ARG APT_DEPS="libsasl2-dev freetds-bin build-essential
default-libmysqlclient-dev apt-utils curl rsync netcat locales"
+
+ENV PATH="$HOME/.npm-packages/bin:$PATH"
+
+RUN if [ -n "${APT_DEPS}" ]; then apt install -y $APT_DEPS; fi \
+ && apt autoremove -yqq --purge \
+ && apt clean
+
+COPY . /opt/airflow/
WORKDIR /opt/airflow
RUN set -x \
&& apt update \
- && if [ -n "${APT_DEPS}" ]; then apt install -y $APT_DEPS; fi \
+ && if [ -n "${buildDeps}" ]; then apt install -y $buildDeps; fi \
+ && curl -sL https://deb.nodesource.com/setup_11.x | bash - \
+ && apt install -y nodejs \
Review comment:
@verdan is the author of the npm stuff, therefore I've tagged him to review.
Maybe he can give some guidance on the versions as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
