ashb commented on a change in pull request #4742: [AIRFLOW-3929] Use anchor
tags for modal links.
URL: https://github.com/apache/airflow/pull/4742#discussion_r259262179
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -315,6 +315,19 @@ <h4 class="modal-title" id="dagModalLabel">
var task_id = '';
var exection_date = '';
var subdag_id = '';
+
+ var buttons = {
+ subDag: {elem: document.querySelector('#btn_subdag'), url: '{{ url_for(
'Airflow.' + dag.get_default_view() ) }}'},
Review comment:
@mik-laj In your example you set a data-href attribute to a URL, and then
have JS that set's the href based on that - why not set href directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
