ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-466743180
 
 
   @astahlman 
   I did assume `airflow upgraded ` was already in the docs, if not we should 
take a look at this. Shall I do this in the same PR?
   
   About the colours, I can make an extra step in the migration to also fill 
the color in task_instance, this is maybe cleaner. Should not take a lot of 
time.
   
   About this `null` and `0`. I did see the same issue at some point. Din't 
pursue this because it did seems to work. At some point I did see things like 
this:
   ```
   edge = DagEdge()
   edge.grapg_id = 0
   session.add(edge)
   ```
   After doing this sqlalchemy did push a null to the database. This was a bit 
unexpected behaviour. 
   Everything seems to work so I din't look into it anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to