ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges 
to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r259609504
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -3988,7 +4042,7 @@ def cli(self):
     def create_dagrun(self,
                       run_id,
                       state,
-                      execution_date=None,
+                      execution_date,
 
 Review comment:
   This method is tested a lof times. An dagrun always should have an execution 
date so making it required does makes more sense. And yes I did found some 
places where this was not used correctly and fixed those in the long run of 
fixing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to