[
https://issues.apache.org/jira/browse/AIRFLOW-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776216#comment-16776216
]
ASF GitHub Bot commented on AIRFLOW-3942:
-----------------------------------------
drewsonne commented on pull request #4761: [AIRFLOW-3942] Expose FAB args to
plugins
URL: https://github.com/apache/airflow/pull/4761
Currently, only a subset of options for flask_appbuilder_views and
flask_appbuilder_menu_links are passed down to FAB. This change exposes all the
arguments from appbuilder.add_link and appbuilder.add_view to the plugin author.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The plugin framework only allows the plugin author to access a preset of the
FAB add_view and add_link arguments. This means authors can't do things like
set 'href' for their plugin links.
This change also suggests deprecating the transform where the plugins use
'view', and airflow transforms this to 'baseview' when calling add_view. I
would like to propose that to reduce surprises and lean on the existing FAB
documentation, we don't use 'view', and instead use the same arg names as FAB,
in this case 'baseview'.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
No change to business logic.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow customisable FAB views and menulinks
> ------------------------------------------
>
> Key: AIRFLOW-3942
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3942
> Project: Apache Airflow
> Issue Type: Improvement
> Components: plugins
> Affects Versions: 1.10.2
> Reporter: Drew Sonne
> Assignee: Drew Sonne
> Priority: Major
> Fix For: 1.10.3
>
>
> Currently, only a subset of options for flask_appbuilder_views and
> flask_appbuilder_menu_links are passed down to FAB. This change exposes all
> the arguments from {{appbuilder.add_link}} and {{appbuilder.add_view}} to the
> plugin author.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
