[
https://issues.apache.org/jira/browse/AIRFLOW-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776593#comment-16776593
]
ASF GitHub Bot commented on AIRFLOW-2551:
-----------------------------------------
fenglu-g commented on pull request #4769: [AIRFLOW-2551] Fix improper failed
session commit handling
URL: https://github.com/apache/airflow/pull/4769
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2511
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
The bug is caused by improper clean up of failed session commit. This PR
pulls out the per-task db manipulations within its own session through
provide_session decorator. In the event a single commit fails, the decorate
will ensure the session is properly flushed and closed.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This PR passes the tests.test_jobs unit test.
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Encode binary data with base64 standard rather than base64 url
> --------------------------------------------------------------
>
> Key: AIRFLOW-2551
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2551
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Hongyi Wang
> Assignee: Hongyi Wang
> Priority: Major
> Fix For: 2.0.0
>
>
> When we try to load mysql data into Google BigQuery (mysql -> gcs -> bq),
> there is a binary filed (uuid), which will cause BigQuery job failed, with
> message "_Could not decode base64 string to bytes. Field: uuid; Value:
> _gJbkmC1QTiS-zZ46uiHWg==_"
> This was caused by "_col_val = base64.urlsafe_b64encode(col_val)_" in
> mysql_to_gcs_operator.
> We should use "_standard_b64encode()_" instead.
> {quote}{{Base64url encoding is basically base64 encoding except they use
> non-reserved URL characters (e.g. – is used instead of + and _ is used
> instead of /) __ }}
> {quote}
> Related to [AIRFLOW-2169]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
