feng-tao commented on a change in pull request #4845: [AIRFLOW-4020] Remove viewer DAG edit permissions URL: https://github.com/apache/airflow/pull/4845#discussion_r262696111
########## File path: tests/www/test_views.py ########## @@ -1566,6 +1566,14 @@ def test_tree_view_for_viewer(self): resp = self.client.get(url, follow_redirects=True) self.check_content_in_response('runme_1', resp) + def test_gantt_failure_for_viewer(self): + url = 'gantt?dag_id=example_bash_operator' + self.logout() + self.login(username='test_viewer', + password='test_viewer') + resp = self.client.get(url, follow_redirects=True) + self.check_content_not_in_response('example_bash_operator', resp) Review comment: sorry, wrong unit test. I changed to use /refresh endpoint instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services