[
https://issues.apache.org/jira/browse/AIRFLOW-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785519#comment-16785519
]
ASF GitHub Bot commented on AIRFLOW-2888:
-----------------------------------------
ashb commented on pull request #4851: [AIRFLOW-2888] Add deprecation path for
task_runner config change
URL: https://github.com/apache/airflow/pull/4851
Make sure you have checked _all_ steps below.
### Jira
https://issues.apache.org/jira/browse/AIRFLOW-2888 (extending the change
introduced in this Jira to provide a deprecation/upgrade path.)
### Description
This change allows users to seamlessly upgrade without a hard-to-debug
error when a task is actually run. This allows us to pull the change
introduced in #3740 to 1.10.3 whilst still being nice to our users.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: tests added
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Do not use Shell=True and bash to launch tasks
> ----------------------------------------------
>
> Key: AIRFLOW-2888
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2888
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Bolke de Bruin
> Priority: Major
> Fix For: 2.0.0
>
>
> Using shell=True is a security risk and there is no need to use bash
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
