[ 
https://issues.apache.org/jira/browse/AIRFLOW-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786745#comment-16786745
 ] 

ASF GitHub Bot commented on AIRFLOW-3842:
-----------------------------------------

jrderuiter commented on pull request #4869: [AIRFLOW-3842] Remove DagBag from 
/duration.
URL: https://github.com/apache/airflow/pull/4869
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3833
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI 
changes:
   
   - Removes dependency on dagbag in the rendered endpoint, similar to earlier 
PR's such as #4831. 
   - Fixes issue with missing metadata argument (json.loads fails on None)
   - Refactors function to make try/except around handler.read more explicit.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Covered by existing tests.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes 
how to use it.
   
   Not applicable.
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove DagBag from /duration
> ----------------------------
>
>                 Key: AIRFLOW-3842
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3842
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webserver
>            Reporter: Peter van 't Hof
>            Assignee: Julian de Ruiter
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to