SalAlba commented on a change in pull request #10864:
URL: https://github.com/apache/airflow/pull/10864#discussion_r488781622



##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -157,7 +165,7 @@ def _serialize_cell(cell, conn):
         """
         return cell
 
-    def get_iam_token(self, conn):
+    def get_iam_token(self, conn: connection) -> Tuple[str, str, int]:

Review comment:
       the arg `conn`  of  method `get_iam_token(...)`, is airflow connection 
or the direct connection to PostgreSQL ? 
   
   1. like this `self.connection` is an Airflow Connection class so it provides 
information on what parameters should be used for establishing PostgreSQL 
connection.
   2. like this  `self.conn` is direct connection to PostgreSQL.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to