michalslowikowski00 commented on pull request #10814:
URL: https://github.com/apache/airflow/pull/10814#issuecomment-696609039


   > > Looks good to me.
   > > Personally I would love to see:
   > > 
   > > * example DAG 
(https://github.com/apache/airflow/tree/master/airflow/providers/microsoft/azure/example_dags)
   > > * system test 
(https://github.com/apache/airflow/tree/master/tests/providers/microsoft/azure/operators)
   > > * documentation 
(https://github.com/apache/airflow/tree/master/docs/howto/operator)
   > > 
   > > There are no docs about Azure and Microsoft operators at all. You could 
be a pioneer and add docs and make a good example for future contributors. :)
   > > I am sorry for such late review. :(
   > 
   > Yeah, I plan to actively work on example dags on this provider and some 
others but I'm thinking of starting it up on a separate PR. Currently, there's 
no SystemTest class for this provider. Do you suggest I start SystemTests with 
this PR or Create another one and do example dags with tests in separate PRs?
   
   IMHO SystemTest could be in separate PR but example dag should be in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to