pcandoalmeida commented on a change in pull request #11067: URL: https://github.com/apache/airflow/pull/11067#discussion_r493043086
########## File path: tests/upgrade/rules/test_send_grid_moved.py ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from unittest import TestCase + +from airflow.upgrade.rules.send_grid_moved import SendGridEmailerMovedRule +from tests.test_utils.config import conf_vars + + +class TestSendGridEmailerMovedRule(TestCase): + + @conf_vars({("email", "email_backend"): "airflow.contrib.utils.sendgrid"}) + def test_invalid_check(self): + rule = SendGridEmailerMovedRule() + + assert isinstance(rule.description, str) + assert isinstance(rule.title, str) + + email_provider_path = "airflow.providers.sendgrid.utils.emailer" + msg = "Email backend option uses airflow.contrib module. Please use new module: {}".format( + email_provider_path) + response = rule.check() + assert response, [msg] Review comment: Right! I checked `test_conn_type_is_not_nullable` for the syntax, but thanks again 😃 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
