potiuk commented on pull request #11110:
URL: https://github.com/apache/airflow/pull/11110#issuecomment-697896866


   OK. I know. the tests did not pass. I apparently merged it when things were 
green but the tests were not yet started @francescomucio  ->  I think I know 
why this happened (the variables should not be set in CI), 
   
   I think eventually this is yet another stronger case to move 
"--start-airflow" flag to "start-airflow" command and make those flags 
re-applied then only for that command. 
   
   BTW. I think we need to be rather careful when merging changes with the 
"green" button but the number of checks are not as expected @kaxil @dimberman 
@ash @turbaszek @mik-laj :  Sometimes the button gets green when some tests are 
still not queued. I raised the github support issue 
https://github.community/t/merge-button-green-with-jobs-not-started-in-github-actions/132604/5
 and after some ping-pong they confirmed the issue, so I raised an official 
ticket to fix that. Let's see.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to