turbaszek commented on pull request #11132:
URL: https://github.com/apache/airflow/pull/11132#issuecomment-703483096
@Sangarshanan it seems that one test is failing:
```
_
TestStatNameHandlerNotSupportedRule.test_check_failed[plugins0--stat_name_handler
field is no longer supported in AirflowTestPlugin. stat_name_handler option in
[scheduler] section in airflow.cfg should be used to achieve the same effect.] _
self =
<tests.upgrade.rules.test_stat_name_handler_not_supported.TestStatNameHandlerNotSupportedRule
object at 0x7f6224a8ca50>
plugins = [<class
'tests.upgrade.rules.test_stat_name_handler_not_supported.MockPluginWithStatNameHandler'>,
<class 'tests.plugins.test_plugin.MockPluginA'>]
test_config = ''
expected = 'stat_name_handler field is no longer supported in
AirflowTestPlugin. stat_name_handler option in [scheduler] section in
airflow.cfg should be used to achieve the same effect.'
@pytest.mark.parametrize(
'plugins, test_config, expected',
[
(PLUGINS_WITH_STAT_NAME_HANDLER, "", CHECK_ERR_MSG),
(PLUGINS_WITHOUT_STAT_NAME_HANDLER, "", None),
(PLUGINS_WITHOUT_STAT_NAME_HANDLER, TEST_CONFIG, None),
(PLUGINS_WITH_STAT_NAME_HANDLER, TEST_CONFIG, None),
]
)
def test_check_failed(self, plugins, test_config, expected):
rule = StatNameHandlerNotSupportedRule()
assert isinstance(rule.description, str)
assert isinstance(rule.title, str)
test_conf = AirflowConfigParser()
test_conf.read_string(test_config)
mock_conf =
mock.patch("airflow.upgrade.rules.stat_name_handler_not_supported.conf",
test_conf)
with mock_plugin_manager(plugins=plugins), mock_conf:
msg = rule.check()
> assert msg == expected
E AssertionError: assert None == ('stat_name_handler field is no
longer supported in AirflowTestPlugin. '\n 'stat_name_handler option in
[scheduler] section in airflow.cfg should be '\n 'used to achieve the same
effect.')
E +None
E -'stat_name_handler field is no longer supported in
AirflowTestPlugin. stat_name_handler option in [scheduler] section in
airflow.cfg should be used to achieve the same effect.'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
