[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211702#comment-17211702 ]
ASF GitHub Bot commented on AIRFLOW-6585: ----------------------------------------- mcepok commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r502790183 ########## File path: airflow/kubernetes/refresh_config.py ########## @@ -24,15 +24,22 @@ import logging import os import time -from datetime import datetime from typing import Optional +import pendulum import yaml from kubernetes.client import Configuration from kubernetes.config.exec_provider import ExecProvider from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader +def _parse_timestamp(ts_str: str) -> int: + parsed_dt = pendulum.parse(ts_str) + if isinstance(parsed_dt, pendulum.DateTime): Review comment: The problem is, that pendulum.parse type annotations says it return `typing.Union[Date, Time, DateTime, Duration]`, however not all of these implement `timetuple()`. One of the CI tests (I guess it was mypy) yelled at me for not covering the other possible return types. I was not able to find an input string which didn't result in either a parser error or in a return type DateTime so it doesn't really matter I guess. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Timestamp bug in RefreshKubeConfigLoader > ---------------------------------------- > > Key: AIRFLOW-6585 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6585 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes, executors, hooks > Affects Versions: 1.10.7 > Reporter: Jan Brusch > Assignee: Jan Brusch > Priority: Major > > When using the KubernetesPodOperator on an aws kubernetes cluster, the > aws-iam-authenticator is used to obtain kubernetes authentication tokens. The > aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in > case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting > the "Z" timezone into a regular "+0000" format. > Upon further review this is only a problem with python version <= 3.6. But > that should not keep the issue from being fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)