[
https://issues.apache.org/jira/browse/AIRFLOW-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216652#comment-17216652
]
ASF GitHub Bot commented on AIRFLOW-6829:
-----------------------------------------
mik-laj edited a comment on pull request #7450:
URL: https://github.com/apache/airflow/pull/7450#issuecomment-712098622
I finished this PR, but there is a minor problem if we want to be compatible
with Airflow 1.10 and still release packages for Airflow. 1.10.
The `airflow.utils.decorators.apply_defaults` decorator displays deprecation
warnings (it's okey). The problem is that we should update all operators and
delete invocation of this decorator so that these warnings will not appear. But
we cannot do that if we want to keep release backport packages, because in
Airflow 1.10, this decorator is still required. We also can't add this
decorator with Bowler, because Bowler could get lost in the class hierarchy and
it's too complex so I can't trust him.
I can see several solutions:
- Merge unchanged and warnings will be displayed in Airflow 2.0 alpha and
Breeze. The backport provider will still work properly.
- Add a bowler refactor for the provider packages for Airflow 2.0 that will
delete this decorator. Previously, provider package didn't have any bowler
refactors, so that would be new.
- Conditionally display warnings for Breeze. Once the user is in the breeze
then they will not see the warning.
Is this at all a problem that we should be worried about? Maybe it's okay
for developer users to see additional deprecation warnings. End users will not
be affected by this change now.
@ashb @kaxil @potiuk WDYT? It would be nice if we could include these
changes into the next alpha.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Auto apply apply_default decorator to all sub-classess
> ------------------------------------------------------
>
> Key: AIRFLOW-6829
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6829
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
> Affects Versions: 1.10.9
> Reporter: Kamil Bregula
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
