potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r517962043



##########
File path: dev/provider_packages/refactor_provider_packages.py
##########
@@ -26,7 +26,7 @@
 from fissix.fixer_util import Comma, KeywordArg, Name
 from fissix.pytree import Leaf
 
-from provider_packages.prepare_provider_packages import (
+from dev.provider_packages.prepare_provider_packages import (

Review comment:
       I still do not like relative imports. They introduce more problems that 
they solve. I prefer to make assumption that the root of our repository is root 
of pythin sources and start from there. This is a really safe assumption




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to