potiuk commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r518720081
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,11 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
Review comment:
This way @ashb -> we do not have any dynamic importing while
building/preparing the packages. IMHO it's much more robust and healthy if the
version is hard-coded. It is especially a problem in case we want to import
stuff like "EXTRAS" etc in setup.py and run those check in various
"environments" - for example in pre-commits and in case of scripts that are
running outside of "airflow" folder, or when we have airflow installed as pypi
package rather than fro sources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
