[ https://issues.apache.org/jira/browse/AIRFLOW-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794992#comment-16794992 ]
ASF GitHub Bot commented on AIRFLOW-4111: ----------------------------------------- zhongjiajie commented on pull request #4933: [AIRFLOW-4111] Auto config airflow_db to database in initdb URL: https://github.com/apache/airflow/pull/4933 Make `airflow initdb` auto configure `airflow_db` by reading and parsing alchemy url in `airflow.cfg` section `[core]` param `sql_alchemy_conn` `airflow_db` work on UI `Data profiling/Ad Hoc Query` and `Data profiling/Known Events` but using default constant values which not user friendly, specially `Data profiling/Known Events` use conn_id `airflow_db` as example Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-4111\], code changes always need a Jira issue. - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)). - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Description - [x] Here are some details about my PR: Make `airflow initdb` auto configure `airflow_db` by reading and parsing alchemy url in `airflow.cfg` section `[core]` param `sql_alchemy_conn` `airflow_db` work on UI `Data profiling/Ad Hoc Query` and `Data profiling/Known Events` but using default constant values which not user friendly, specially `Data profiling/Known Events` use conn_id `airflow_db` as example ### Tests - [x] My PR adds the following unit tests: Add test in `airflow/test/utils/test_db` ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. - All the public functions and the classes in the PR contain docstrings that explain what it does - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release ### Code Quality - [x] Passes `flake8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Auto config airflow_db to database in initdb > -------------------------------------------- > > Key: AIRFLOW-4111 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4111 > Project: Apache Airflow > Issue Type: Improvement > Components: db > Affects Versions: 1.10.2 > Reporter: zhongjiajie > Assignee: zhongjiajie > Priority: Minor > Labels: features > Fix For: 1.10.3 > > > Make `airflow initdb` auto configure `airflow_db` by reading and parsing > alchemy url in `airflow.cfg` section `[core]` param `sql_alchemy_conn`. > > `airflow_db` work on UI `Data profiling/Ad Hoc Query` and > `Data profiling/Known Events` but using default constant values > which not user friendly, specially `Data profiling/Known Events` > use conn_id `airflow_db` as example. > > And as we know that `airflow_db`, airflow backend database, are > already define in `airflow.cfg` section `[core]` paratemeter > `sql_alchemy_conn` but alchemy url type, this Jira ticket help us > make it real. -- This message was sent by Atlassian JIRA (v7.6.3#76005)