XD-DENG commented on issue #4933: [AIRFLOW-4111] Auto config airflow_db to 
database in initdb
URL: https://github.com/apache/airflow/pull/4933#issuecomment-473927612
 
 
   Hi @zhongjiajie I have had a quick check.
   
   I think it's changing the behaviour, and may cause concern (in my person 
opinion): Users have been used to the behaviour that all the default 
connections are somehow "fake" and they know that they need to go there 
configure explicitly.
   
   Another example: I may be using a `read+write` DB account for 
`sql_alchemy_conn` (`write` permission must be provided), while I will use a 
`read_only` DB account for `airflow_db`. But your change will use the 
`read+write` DB account info in `sql_alchemy_conn` to configure `airflow_db`, 
which should not happen by default.
   
   IMO, the concerns this PR brings > the pros it brings (also given that `Data 
profiling/Ad Hoc Query/Known Events` are all deprecated). Personally I would 
not merge it.
   
   Hope this clarifies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to