fhoda commented on a change in pull request #12360:
URL: https://github.com/apache/airflow/pull/12360#discussion_r523304249
##########
File path: airflow/providers/google/cloud/secrets/secret_manager.py
##########
@@ -89,11 +92,12 @@ def __init__(
self.variables_prefix = variables_prefix
self.config_prefix = config_prefix
self.sep = sep
- if not self._is_valid_prefix_and_sep():
- raise AirflowException(
- "`connections_prefix`, `variables_prefix` and `sep` should "
- f"follows that pattern {SECRET_ID_PATTERN}"
- )
+ if connections_prefix is not None:
+ if not self._is_valid_prefix_and_sep():
+ raise AirflowException(
+ "`connections_prefix`, `variables_prefix` and `sep` should
"
+ f"follows that pattern {SECRET_ID_PATTERN}"
+ )
Review comment:
This one is a little different from the others, as it checks if the
prefix and sep are valid. But the function `_is_valid_prefix_and_sep` only
seems to really check the `connections_prefix` with `sep`, and not
`variables_prefix` or `config_prefix`. So the added condition reflects this
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
