[GitHub] [airflow] potiuk commented on a change in pull request #12384: Make K8sPodOperator backwards compatible

[GitBox]

potiuk commented on a change in pull request #12384:
URL: https://github.com/apache/airflow/pull/12384#discussion_r525020789



##########
File path: dev/provider_packages/refactor_provider_packages.py
##########
@@ -146,6 +146,13 @@ def rename_deprecated_modules(self) -> None:
         for new, old in changes:
             self.qry.select_module(new).rename(old)
 
+        def is_not_k8spodop(node: LN, capture: Capture, filename: Filename) -> 
bool:
+            return not filename.endswith("/kubernetes_pod.py")
+
+        
self.qry.select_module("airflow.providers.cncf.kubernetes.backcompat").filter(
+            callback=is_not_k8spodop
+        ).rename("airflow.kubernetes")

Review comment:
       One small thing that we could do - maybe also remove the backcompat 
classes. They seem to not be removed during the refactoring and they are not 
needed in the backport at all:
   
   
![image](https://user-images.githubusercontent.com/595491/99374141-91370280-28c2-11eb-8bc8-53b85bbeb601.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org