aaltay commented on a change in pull request #12249:
URL: https://github.com/apache/airflow/pull/12249#discussion_r527893973
##########
File path: airflow/providers/google/cloud/sensors/dataflow.py
##########
@@ -187,4 +192,196 @@ def poke(self, context: dict) -> bool:
location=self.location,
)
+ if self.fail_on_terminal_state:
Review comment:
This is inconsistent with: fetch_job_autoscaling_events_by_id,
fetch_job_messages_by_id. Here we first query and then fail if job is in a
terminal state. The other cases do the opposite. I think this option is better
because, a job may reach to a terminal state after the initial query. Either
way it will be good to use the same logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
