kaxil opened a new pull request #12603:
URL: https://github.com/apache/airflow/pull/12603


   closes https://github.com/apache/airflow/issues/12448
   
   https://github.com/apache/airflow/pull/12586 didn't fully solve the issue. I 
was getting the following error:
   
   ```
       def clear(dest, dest_mapper, synchronize_pairs):
           for l, r in synchronize_pairs:
               if (
                   r.primary_key
                   and dest_mapper._get_state_attr_by_column(dest, dest.dict, r)
                   not in orm_util._none_set
               ):
   
                   raise AssertionError(
                       "Dependency rule tried to blank-out primary key "
   >                   "column '%s' on instance '%s'" % (r, 
orm_util.state_str(dest))
                   )
   E               AssertionError: Dependency rule tried to blank-out primary 
key column 'job.id' on instance '<BaseJob at 0x7f42c08ac630>'
   
   /usr/local/lib/python3.6/site-packages/sqlalchemy/orm/sync.py:88: 
AssertionError
   ```
   
   This PR also fixes the issues completely for DagRun and fixes it for 
clearing taskInstances too from the UI
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to