potiuk commented on pull request #12466: URL: https://github.com/apache/airflow/pull/12466#issuecomment-735347672
> You're missing a lot more actually: Bringing those connections in which were not defined in the original "connection.py" is non -goal of that change. If we are planning to add all missing connections (I certainly did not) this should be a follow-up PR. I only converted those connections that have already been defined and I left up to provider to define which connections should be added. I explained it in this comment yesterday @ashb: https://github.com/apache/airflow/pull/12466#discussion_r532059119 I think it requires much more than just bringing those, we need to define some standard approach for those - what should we do with those hooks that have hierarchy (see all amazon hooks). How should we define connection names for those? Do we have any guidelines that you can point me to @ashb ? Maybe (if you want to bring them in) - you can make a proposal for that (but still I would leave it to a follow-up PR). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
