potiuk commented on a change in pull request #12740:
URL: https://github.com/apache/airflow/pull/12740#discussion_r533573759



##########
File path: tests/cli/commands/test_db_command.py
##########
@@ -56,13 +56,13 @@ def test_cli_upgradedb(self, mock_upgradedb):
 
     @mock.patch("airflow.cli.commands.db_command.execute_interactive")
     @mock.patch("airflow.cli.commands.db_command.NamedTemporaryFile")
-    @mock.patch("airflow.cli.commands.db_command.settings.engine.url", 
make_url("mysql://root@mysql/airflow"))

Review comment:
       Why don't we parameterise the tests and add with/without port 
mysql/postgres?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to