turbaszek commented on a change in pull request #12704:
URL: https://github.com/apache/airflow/pull/12704#discussion_r533799409



##########
File path: tests/cli/commands/test_task_command.py
##########
@@ -55,6 +55,7 @@ def reset(dag_id):
         runs.delete()
 
 
+# TODO: Check if tests needs side effects - locally there's missing DAG

Review comment:
       > I can test that and fix it if that is the case in a separate PR
   
   Thanks for helping! The problems I observed:
   ```
   root@01658a8a09d3:/opt/airflow# pytest -s 
tests/cli/commands/test_task_command.py
   ...
   
=============================================================================================
 short test summary info 
==============================================================================================
   SKIPPED [1] tests/conftest.py:313: The test is skipped because it has 
quarantined marker. And --include-quarantined flag is passed to pytest. 
<TestCaseFunction test_local_run>
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks - 
airflow.exceptions.AirflowException: dag_id could not be found: 
example_bash_operator. Either the dag did not exist or it fai...
   FAILED tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run - 
airflow.exceptions.AirflowException: dag_id could not be found: 
example_bash_operator. Either the dag did not exist or it failed to ...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_0__ignore_all_dependencies
 - AssertionError: "Option --raw does not work with some of the other options 
on this com...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_1__ignore_depends_on_past
 - AssertionError: "Option --raw does not work with some of the other options 
on this comm...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_2__ignore_dependencies
 - AssertionError: "Option --raw does not work with some of the other options 
on this command...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_3__force
 - AssertionError: "Option --raw does not work with some of the other options 
on this command." does not ma...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_mutually_exclusive
 - AssertionError: "Option --raw and --local are mutually exclusive." does not 
match "dag_id could not be found: exa...
   FAILED tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test 
- airflow.exceptions.AirflowException: dag_id could not be found: 
example_bash_operator. Either the dag did not exist or it failed to...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_env_vars
 - airflow.exceptions.AirflowException: dag_id could not be found: 
example_passing_params_via_test_command. Either the d...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_params
 - airflow.exceptions.AirflowException: dag_id could not be found: 
example_passing_params_via_test_command. Either the dag...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_parentdag_downstream_clear
 - airflow.exceptions.AirflowException: dag_id could not be found: 
example_subdag_operator.section-1. Either the dag...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_subdag_clear - 
airflow.exceptions.AirflowException: dag_id could not be found: 
example_subdag_operator. Either the dag did not exist or it fai...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_task_state - 
airflow.exceptions.AirflowException: dag_id could not be found: 
example_bash_operator. Either the dag did not exist or it failed ...
   FAILED 
tests/cli/commands/test_task_command.py::TestCliTasks::test_task_states_for_dag_run
 - KeyError: 'example_python_operator'
   FAILED tests/cli/commands/test_task_command.py::TestCliTasks::test_test - 
airflow.exceptions.AirflowException: dag_id could not be found: 
example_python_operator. Either the dag did not exist or it failed to p...
   FAILED 
tests/cli/commands/test_task_command.py::TestLogsfromTaskRunCommand::test_logging_with_run_task
 - AssertionError: 2 != 1
   
=============================================================================== 
16 failed, 6 passed, 1 skipped, 1 warning in 41.37s 
================================================================================
   ```
   
   This is what I get using brezee and current main branch. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to