XD-DENG opened a new issue #12818:
URL: https://github.com/apache/airflow/issues/12818


   As discussed in 
https://github.com/apache/airflow/pull/12815#discussion_r536283503 and pointed 
out at 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#database-session-handling,
 we should not have `session.commit()` when `@provide_session` decorator is 
used (for principle "Explicit is better than implicit").
   
   This issue exists in files like 
https://github.com/apache/airflow/blob/2936c13a44369daae9d6099cd1070b3a8cd53443/airflow/models/dag.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to