XD-DENG commented on a change in pull request #12815:
URL: https://github.com/apache/airflow/pull/12815#discussion_r536326980
##########
File path: airflow/models/dag.py
##########
@@ -1966,7 +1966,7 @@ def deactivate_stale_dags(expiration_date, session=None):
)
dag.is_active = False
session.merge(dag)
- session.commit()
+ session.commit()
Review comment:
I created issue https://github.com/apache/airflow/issues/12818 for
clearing `session.commit()`.
Given it's a relatively easy fix to do, I mark it as "**good first issue**"
and let's see if any new-contributor would like to pick it up (will voice in
Slack).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
