ashb commented on a change in pull request #13058:
URL: https://github.com/apache/airflow/pull/13058#discussion_r542683198
##########
File path: airflow/configuration.py
##########
@@ -69,7 +69,9 @@ def run_command(command):
process = subprocess.Popen(
shlex.split(command), stdout=subprocess.PIPE, stderr=subprocess.PIPE,
close_fds=True
)
- output, stderr = [stream.decode(sys.getdefaultencoding(), 'ignore') for
stream in process.communicate()]
+ output, stderr = [
+ stream.decode(sys.getdefaultencoding(), 'ignore') for stream in
process.communicate(timeout=60)
Review comment:
This case is to run command from the `*_CMD` vars, for instance
`sqlalchemy_conn_cmd` setting.
60s is fine for most sensible cases (probably too long), but we just can't
know what users might put in these configs -- it might take a long time on
first instance.
Perhaps we just document this as a limitation for now and we can make it
configurable when someone complains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
