[
https://issues.apache.org/jira/browse/AIRFLOW-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805315#comment-16805315
]
ASF GitHub Bot commented on AIRFLOW-3623:
-----------------------------------------
ashb commented on pull request #5005: [AIRFLOW-3623] Fix bugs in Download task
logs
URL: https://github.com/apache/airflow/pull/5005
Make sure you have checked _all_ steps below.
### Jira
- [x] https://issues.apache.org/jira/browse/AIRFLOW-3623
### Description
- [x] They didn't work in Python 3 (Bytes vs Strings), the graph_view wasn't
specifying the try_number correctly, and the "All" logs had "None" as
the suffix instead of "all".
/cc @zhongjiajie
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: I maybe should have added better tests for this...
Hmm
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support download log file from UI
> ---------------------------------
>
> Key: AIRFLOW-3623
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3623
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
> Reporter: Ping Zhang
> Assignee: Ping Zhang
> Priority: Major
> Labels: newbie
> Fix For: 1.10.3
>
>
> for some large log files, it is not a good idea to fetch and render in the
> UI. Adding the ability to let users to download by try_number in the dag
> modal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
