mik-laj commented on a change in pull request #5005: [AIRFLOW-3623] Fix bugs in
Download task logs
URL: https://github.com/apache/airflow/pull/5005#discussion_r270603410
##########
File path: airflow/www/templates/airflow/graph.html
##########
@@ -169,9 +169,9 @@
d3.selectAll("g.node").on("click", function(d){
task = tasks[d];
if (task.task_type == "SubDagOperator")
- call_modal(d, execution_date, true);
+ call_modal(d, execution_date, task_instances[d].try_number, true);
else
- call_modal(d, execution_date);
+ call_modal(d, execution_date,task_instances[d].try_number);
Review comment:
Javascript is not analyzed by the linter. I am working on a PR that will
delete the jinja directives from Javascript code so that the linter can read
the files correctly.
Reference:
https://github.com/apache/airflow/pull/4787
Other peoples also working on linting:
https://github.com/apache/airflow/pull/3656
I have a ready patch that integrates the linter with Travis, but is waiting
for the right moment.
https://github.com/PolideaInternal/airflow/pull/75/files
I hope my explanations will be helpful to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
