feluelle commented on a change in pull request #4842: [AIRFLOW-4014] Change
DatastoreHook and add tests
URL: https://github.com/apache/airflow/pull/4842#discussion_r270606155
##########
File path: airflow/contrib/hooks/datastore_hook.py
##########
@@ -19,58 +19,73 @@
#
import time
+
from googleapiclient.discovery import build
+
from airflow.contrib.hooks.gcp_api_base_hook import GoogleCloudBaseHook
class DatastoreHook(GoogleCloudBaseHook):
"""
- Interact with Google Cloud Datastore. This hook uses the Google Cloud
Platform
- connection.
+ Interact with Google Cloud Datastore. This hook uses the Google Cloud
Platform connection.
This object is not threads safe. If you want to make multiple requests
simultaneously, you will need to create a hook per thread.
+
+ :param version: The version of the API it is going to connect to.
+ :type version: str
"""
- def __init__(self,
- datastore_conn_id='google_cloud_datastore_default',
- delegate_to=None):
+ def __init__(self, datastore_conn_id='google_cloud_datastore_default',
delegate_to=None, version='v1'):
Review comment:
Agree. I like `api_version` more. I've changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
