kaxil commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r582229481
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -69,8 +69,8 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
conn_name_attr = 'gcp_conn_id'
default_conn_name = 'google_cloud_default'
- conn_type = 'google_cloud_platform'
- hook_name = 'Google Cloud'
+ conn_type = 'bigquery'
+ hook_name = 'BigQuery'
Review comment:
Yes probably add an Updating.md style note in `ADDITIONAL_INFO.md` with
version ad header -- same as
https://github.com/apache/airflow/blob/master/UPDATING.md
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -69,8 +69,8 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
conn_name_attr = 'gcp_conn_id'
default_conn_name = 'google_cloud_default'
- conn_type = 'google_cloud_platform'
- hook_name = 'Google Cloud'
+ conn_type = 'bigquery'
+ hook_name = 'BigQuery'
Review comment:
Yes probably add an Updating.md style note in `ADDITIONAL_INFO.md` with
version as header -- same as
https://github.com/apache/airflow/blob/master/UPDATING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
