dstandish commented on a change in pull request #11350:
URL: https://github.com/apache/airflow/pull/11350#discussion_r582285327
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -144,3 +145,17 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
def get_autocommit(self, conn):
return getattr(conn, 'autocommit_mode', False)
+
+ def run(self, sql, autocommit=False, parameters=None):
+ """
+ Snowflake-connector doesn't allow natively the execution of multiple
SQL statements in the same
+ call. So for allowing to pass files or strings with several queries
this method is coded,
Review comment:
@JavierLopezT does this actually support running a file? It looks like
it must be string here.
I think we def should make it so `sql` can be path _or_ sql _(i.e.
Union[Path,str], and if str, check if it's a path to a file that exists)_,
though it doesn't have to be _this_ PR -- I just want to suggest here you make
sure the docstring is consistent here with the behavior.
Sorry missed this before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
