dstandish commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r597437118
##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -52,7 +52,10 @@ def __init__(self, *args, **kwargs) -> None:
def set_autocommit(self, conn: Connection, autocommit: bool) -> None: #
noqa: D403
Review comment:
again this is a good point.
the `mysql` extra installs both connector python and mysqldb so it should be
safe to import both. i don't think we save much by importing locally.
i'll ask around though. please write a test for this also -- it (your
autocommit fix) is testable behavior and i think merits it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
