[ 
https://issues.apache.org/jira/browse/AIRFLOW-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811128#comment-16811128
 ] 

ASF subversion and git services commented on AIRFLOW-4240:
----------------------------------------------------------

Commit dbed51e702bf8177800183d2c4f595073aa2339d in airflow's branch 
refs/heads/master from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=dbed51e ]

[AIRFLOW-4240] State-changing actions should be POST requests (#5044)

To make the requests POSTs and to follow the redirect that the backend
issue I turned the "toggle" buttons in to an actual form, which makes
there much less logic needed to build up the URL - the browser handles
it all for us. The only thing we have to do is set the "action" on the
URL.

For the "link" ones (delete,trigger,refresh) I wrote a short
`postAsForm` which takes the URL and submits a form. A little bit messy,
but it works.

> State changing actions shouldn't be GET requests
> ------------------------------------------------
>
>                 Key: AIRFLOW-4240
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4240
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Ash Berlin-Taylor
>            Priority: Major
>
> We have a number of actions which perform actions (trigger, clear, etc) that 
> are performed over GET requests.
> That should be avoided as browsers/corporate proxies might prefetch the URLs 
> causing things to behave oddly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to