[GitHub] [airflow] ashb commented on a change in pull request #15112: Avoid scheduler/parser manager deadlock by using non-blocking IO

[GitBox]

ashb commented on a change in pull request #15112:
URL: https://github.com/apache/airflow/pull/15112#discussion_r605198494



##########
File path: airflow/utils/dag_processing.py
##########
@@ -141,7 +141,7 @@ def waitable_handle(self):
 class DagParsingStat(NamedTuple):
     """Information on processing progress"""
 
-    file_paths: List[str]
+    num_file_paths: int

Review comment:
       Yes, done, was only used in one test, and that was strictly speaking not 
testing the right thing anymore, just a likely side-effect.
   
   ```diff
   -        assert result.num_file_paths == 3
   +        assert sum(stat.run_count for stat in manager._file_stats.values()) 
== 3
   ```
   
   See 4d8da57eb for full diff.
   
   Good call @XD-DENG 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org