potiuk opened a new pull request #15320:
URL: https://github.com/apache/airflow/pull/15320


   After PROD images were added, some of the flags had two meanings
   
   These behaved differently in PROD image and CI image and were the
   source of confusion especially when start-airflow command was used.
   
   For PROD image, the image can be customized during image building,
   and packages could be installed from .whl or .sdist packages
   available in `docker-context-files`. This
   is used at CI and dockerhub building time to produce image built
   packages that were prepared using local sources.
   
   The CI image is always built from local sources but airflow can
   be removed and re-installed at runtime from pypi.
   Both airflow and provider packages can be installed
   from .whl or .sdist packages available in dist folder. This is
   used in CI to test current provider packages with older
   Airflow released (2.0.0) and to test provider packages locally.
   
   After the change we have two sets of flags/variables:
   
   PROD image (building image):
   
   * install-airflow-version, install-airflow-reference,
     install-from-docker-context-files
   
   CI image (runtime):
   
   * use-airflow-version, use-packages-from-dist
   
   That should avoid confusion and failures of commands such as
   `start-airflow` that is used to test provider packages and
   airflow itself.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to